openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #14216
[Merge] lp:~sfindlay/openlp/bug944510 into lp:openlp
Samuel Findlay has proposed merging lp:~sfindlay/openlp/bug944510 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #944510 in OpenLP: "web remote doesn't scale to screen"
https://bugs.launchpad.net/openlp/+bug/944510
For more details, see:
https://code.launchpad.net/~sfindlay/openlp/bug944510/+merge/95722
BUG FIX:
As per bug #944510, modified index.html so that web remote correctly scales to fill browser viewport. I believe that this was broken when jQuery Mobile was upgraded past beta 1 (previously, jQuery Mobile dynamically added the required tag itself) [1].
Apple uses the 'viewport' meta tag, and although not officially part of HTML5, it seems to be an industry standard, adopted by all the major mobile browsers.
TEST:
Open the web remote in your browser of choice, and check that scaling and functions are as expected.
I have tested on Android default browser and Dolphin HD on Android 2.3 on Samsung Galaxy S.
[1] https://github.com/jquery/jquery-mobile/commit/adf3808e842677feb23e9d1102c7203ab82a42a3
[2] https://developer.apple.com/library/ios/#DOCUMENTATION/AppleApplications/Reference/SafariWebContent/UsingtheViewport/UsingtheViewport.html
--
https://code.launchpad.net/~sfindlay/openlp/bug944510/+merge/95722
Your team OpenLP Core is requested to review the proposed merge of lp:~sfindlay/openlp/bug944510 into lp:openlp.
=== modified file 'openlp/plugins/remotes/html/index.html'
--- openlp/plugins/remotes/html/index.html 2011-12-18 21:02:06 +0000
+++ openlp/plugins/remotes/html/index.html 2012-03-03 05:39:18 +0000
@@ -27,6 +27,7 @@
-->
<head>
<meta charset="utf-8" />
+ <meta name="viewport" content="width=device-width, minimum-scale=1, maximum-scale=1" />
<title>${app_title}</title>
<link rel="stylesheet" href="/files/jquery.mobile.css" />
<link rel="stylesheet" href="/files/openlp.css" />
Follow ups
