openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

The following strings you need to remove the "&" because we're already in String Freeze.

69	+ translate('MediaPlugin.MediaItem', 'Use &Player:'))
139	+ translate('MediaPlugin.MediaTab', 'Player O&rder'))
144	+ '&Allow media player to be overridden'))


The following lines can be slightly rewritten:

    title = mediaPlayers[player].original_name
    self.displayTypeComboBox.addItem(title)

    self.displayTypeComboBox.addItem(mediaPlayers[player].original_name)

-- 
https://code.launchpad.net/~mahfiaz/openlp/bug-903683/+merge/96976
Your team OpenLP Core is subscribed to branch lp:openlp.