openlp-core team mailing list archive

[Meinert Jordan <meinertjordan@xxxxxxxxxx>]

So if you are anyhow at integrating some small fixes:

Line 47: I'd like more to see this as unicode map (instead of str). The result is the same, but I want to rely on the fact, that each string is unicode, if there is not a need for a different string type.

Line 48: You can save the default value, so it will be set in line 50

Line 49: "if not players" is better

Lines 53 and 78: You can remove the default value, as QVariant() != QtCore.Qt.Checked
-- 
https://code.launchpad.net/~crichter/openlp/bug-955992/+merge/98522
Your team OpenLP Core is subscribed to branch lp:openlp.