← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~googol/openlp/search-placeholder into lp:openlp

 

Review: Approve

Technically, PyQt 4.8 should support "setPlaceholderText" since it is supposed to be compatible with Qt 4.7. maybe one of the bugfix releases added support?

I remember trying to add this in about a year ago, but leaving it because 4.6 was the predominant version of Qt at the time.

I'm going to approve this, but I'd really like to see some more testing around which versions supports what in future.
-- 
https://code.launchpad.net/~googol/openlp/search-placeholder/+merge/99279
Your team OpenLP Core is subscribed to branch lp:openlp.


References