openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #14924
[Merge] lp:~googol/openlp/bug-969909 into lp:openlp
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-969909 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #969909 in OpenLP: ""Missing verse tag" warning is not updated after adding a new verse"
https://bugs.launchpad.net/openlp/+bug/969909
For more details, see:
https://code.launchpad.net/~googol/openlp/bug-969909/+merge/100276
Hello,
Fixed bug #969909 ('Missing verse tag' warning is not updated after adding a new verse).
--
https://code.launchpad.net/~googol/openlp/bug-969909/+merge/100276
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/bug-969909 into lp:openlp.
=== modified file 'openlp/plugins/songs/forms/editsongform.py'
--- openlp/plugins/songs/forms/editsongform.py 2012-03-22 21:31:01 +0000
+++ openlp/plugins/songs/forms/editsongform.py 2012-03-31 10:01:23 +0000
@@ -489,6 +489,8 @@
self.verseListWidget.setItem(
self.verseListWidget.rowCount() - 1, 0, item)
self.tagRows()
+ # Check if all verse tags are used.
+ self.onVerseOrderTextChanged(self.verseOrderEdit.text())
def onVerseEditButtonClicked(self):
item = self.verseListWidget.currentItem()
@@ -516,6 +518,8 @@
item.setData(QtCore.Qt.UserRole, tempId[row])
self.verseListWidget.setItem(row, 0, item)
self.tagRows()
+ # Check if all verse tags are used.
+ self.onVerseOrderTextChanged(self.verseOrderEdit.text())
def onVerseEditAllButtonClicked(self):
verse_list = u''
@@ -575,6 +579,8 @@
self.tagRows()
self.verseEditButton.setEnabled(False)
self.verseDeleteButton.setEnabled(False)
+ # Check if all verse tags are used.
+ self.onVerseOrderTextChanged(self.verseOrderEdit.text())
def onVerseDeleteButtonClicked(self):
self.verseListWidget.removeRow(self.verseListWidget.currentRow())
Follow ups