openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #15091
Re: [Merge] lp:~orangeshirt/openlp/bibles into lp:openlp
I've not read each single line, but the code looks nice.
There are some small things (spaces and u''s) you've missed at a lot of places
184 Greate, that you're already using it ;)
207 book name (with space)
211, 214 Combo box items shouls be title case
355, 175, 210, 215, 309, 468 spaces missing
357, 389, 449, 451 u'' missing
314, 320 not sure about capitalisation
--
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/100682
Your team OpenLP Core is requested to review the proposed merge of lp:~orangeshirt/openlp/bibles into lp:openlp.
References