openlp-core team mailing list archive

[Meinert Jordan <meinertjordan@xxxxxxxxxx>]

153: it should be bookNameWidget

159ff: QFormLayout::addRow ( QWidget * label, QWidget * field )

178ff: The spacer takes place, if the scrollArea is visible. use: addStretch()

317f, 330ff: What is that supposed to do?

357: White is the wrong color. It does not work on dark themes. Implement something like:
... color=None):
pal = QtGui.QPalette(self.palette())
if color:
    pal.setColor(QtGui.QPalette.Base,QtGui.QColor(color))

495: return self.save_object(book)

777, 789: if bible:

838, 843: shift linebreaks

637, 743, 761, 811: I personally prefere "is None" as you expect a instance of None

-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/100682
Your team OpenLP Core is requested to review the proposed merge of lp:~orangeshirt/openlp/bibles into lp:openlp.