← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~orangeshirt/openlp/bibles into lp:openlp

 

> 330ff.: If a bible doesn't contain all books it removes all unnecessary ones, so that the user only see bookname that could be changed.
> 317f: If it is a webbible the hole scrollarea is obsolete and removed, because it is not possible to change the booknames.

Well, I understood that so far. But you could just hide the widgets. I see no advantage and the reassigning the parent adds complexity and even some (tiny) more things to process.

> 314, 320 not sure about capitalisation
I think it is ok, because you recommand me to write book name (with space) then I think it is bookNameNotice and not booknameNotice

I thought about the strings, not the names. e.g.: "It is not possible to customize the Book Names."

148, 161: delete

Just realized your strings arround the combo box:
General Settings > Global Settings
The tooltip: remove it. The options should be self-explaining (even if not, users will hardly discover the tooltip). see also pad.lv/960386

But: Users do not know, what is the effect of book names languages. Find a better label or add a explanation text label, that the setting affects the reference search. Are the custom names shown in the slide footer lines?
Maybe discuss the strings with others on IRC. I'm now offline for the next five days.
-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/100682
Your team OpenLP Core is subscribed to branch lp:openlp.


References