openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Review: Needs Fixing

I'm not sure the Bible Editor window needs to be quite as wide as it is. It could be closer to where the text at the top of the Custom Book Names tab wraps perhaps?

The red backgrounds for errors are pretty, but non-standard, please leave them white. 
(If you want to introduce a new UI standard it needs to be discussed on the mailing list, and then if agreed, introduced everywhere at the same time)

Case consistency with the global settings page:
212: -> Global settings
215: -> Bible language
218: -> Application language


316: For consistency: "webbible" -> "Web Download Bible"

321/322: -> 'To use the customized book names, "Bible language" must be selected on the Meta Data tab or, if "Global settings" is selected, on the Bible page in Configure OpenLP.'

359/367: Could you just return at these places, and get rid of the save variable?

439: "Decimal digits only could" -> "Numbers can only"
441: "non-digit" -> "non-numeric"

456: Book Name Exists Twice -> Duplicate Book Name
458: 'The Book Name "%s" exists twice. Please change one.' -> 'The Book Name "%s" has been entered more than once."




-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/101018
Your team OpenLP Core is subscribed to branch lp:openlp.