openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Review: Needs Fixing

239	+                if hasattr(song_xml, u'Version'):
240	+                    self.version = float(song_xml.Version.text)
241	+                # Version numbers found in DreamBeam Source /FileTypes/Song.cs
242	+                if self.version <= 0.49:

You check to see if the Version exists in the XML on line 239 and conditionally set self.version. However on line 242 you assume self.version exists (I couldn't see it being defaulted anywhere else).

If <Version> is optional, self.version needs to have a default. If it is always expected just remove the redundant check on line 239 since it will just crash on 242 anyway if it is missing.
-- 
https://code.launchpad.net/~phill-ridout/openlp/DreamBeam/+merge/101183
Your team OpenLP Core is subscribed to branch lp:openlp.