← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~phill-ridout/openlp/DreamBeam into lp:openlp

 

Review: Needs Fixing

I imported the songs that come with DreamBream.

Great is thy faithfulness:
It added an Author called "None". I'd prefer "Author Unknown", which I think is the one the backend automatically adds anyway if there is no author included, but memory might be rusty.

Also the Song book and Song number were set to "None". Leave these blank if they don't exist.
Also leave Copyright unset if there is no Copyright string rather than None.

I'm aware there is a bit of grey area in the XML as to whether it has an author or copyright string. If it contains a © symbol, please could you put it in the Copyright. If it doesn't, please could you use it as the author, rather than populating both with the same thing.
-- 
https://code.launchpad.net/~phill-ridout/openlp/DreamBeam/+merge/101187
Your team OpenLP Core is subscribed to branch lp:openlp.


References