openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~raoul-snyman/openlp/rename-split into lp:openlp

To: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Sun, 15 Apr 2012 10:04:17 -0000
In-reply-to: <20120413202022.17703.46404.launchpad@ackee.canonical.com>
Reply-to: mp+101971@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

> Virtual split doesn't really make sense to me. Saying it is "optional" provides way more meaning.
I searched the source tree and only found "virtual verse" or "virtual split" in connection with this function. Only, in one place, I have found "optional" in connection with this, namely this line:

    lines_element.set(u'break', u'optional')

So I'd be glad if the other occurrences would be fixed. (We should not introduce two terms for the same thing, as we had it once with "Formatting/Display tags".)
-- 
https://code.launchpad.net/~raoul-snyman/openlp/rename-split/+merge/101971
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~raoul-snyman/openlp/rename-split into lp:openlp
From: Raoul Snyman, 2012-04-13