openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #15452
Re: [Merge] lp:~sfindlay/openlp/songs-import-powersong into lp:openlp
Though still makes sense to replace tab with space, as you suggest.
On May 1, 2012 7:15 AM, "Samuel Findlay" <samuel.findlay@xxxxxxxxx> wrote:
> You're right Phill, the non-printing bytes do specify the length of the
> following field/label. A rewrite based on this info should be more
> efficient.
>
> This may also avoid the need for stripping ascii control characters.
> On May 1, 2012 1:13 AM, "phill" <phill.ridout@xxxxxxxxxxxxxx> wrote:
>
>> One more thing, lines 223 - 229: the "non-printing byte" specifies how
>> many
>> chars (or bytes) long the "label" is. It is not unique to the label, i.e.
>> If you had two labels the same length, the would have the same
>> non-printing
>> byte ay the start.
>>
>> Phill
>>
>> --
>>
>> https://code.launchpad.net/~sfindlay/openlp/songs-import-powersong/+merge/104102
>> You are the owner of lp:~sfindlay/openlp/songs-import-powersong.
>>
>
--
https://code.launchpad.net/~sfindlay/openlp/songs-import-powersong/+merge/104102
Your team OpenLP Core is requested to review the proposed merge of lp:~sfindlay/openlp/songs-import-powersong into lp:openlp.
Follow ups
References