openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol/openlp/trivial into lp:openlp

To: mp+103988@xxxxxxxxxxxxxxxxxx
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Tue, 01 May 2012 07:45:22 -0000
In-reply-to: <20120430104153.9988.13311.codereview@chaenomeles.canonical.com>
Reply-to: mp+103988@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> Receiver.send_message(u'openlp_phonon_creation')  removal needs to be
> considered.  Cannot remember why this was added but it was so what is the
> impact of it's loss.

This was added because the phonon (media object?) creation was slow on some computer. However, we do not connect to this signal no where (I think this changed with the media rewrite). Thus, dead code.
-- 
https://code.launchpad.net/~googol/openlp/trivial/+merge/103988
Your team OpenLP Core is subscribed to branch lp:openlp.

References

Re: [Merge] lp:~googol/openlp/trivial into lp:openlp
From: Tim Bentley, 2012-04-30