← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~sfindlay/openlp/songs-import-powersong into lp:openlp

 

Review: Needs Fixing

253	+ def __init__(self, manager, **kwargs):
254	+ """
255	+ Initialise the PowerSong importer.
256	+ """
257	+ SongImport.__init__(self, manager, **kwargs)

If you're not actually doing something in the constructor, don't bother adding it in.

Otherwise it looks good. I haven't actually tested it out, but I'll do that later.
-- 
https://code.launchpad.net/~sfindlay/openlp/songs-import-powersong/+merge/104102
Your team OpenLP Core is subscribed to branch lp:openlp.


Follow ups

References