openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

249	+ if isinstance(self.importSource, list):

If all you're doing is ensuring that your import source is a list, you might want to negate that if statement, and exit immediately. That way you don't need to have the rest of the code in the method indented one more level. Gives you four extra characters per line :-)


if not isinstance(self.importSource, list):
    self.logError('No files to import.')
    return
for file in self.importSource:
    ...
-- 
https://code.launchpad.net/~sfindlay/openlp/songs-import-powersong/+merge/104254
Your team OpenLP Core is subscribed to branch lp:openlp.