← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~sfindlay/openlp/select-folder-powersong into lp:openlp

To: mp+104915@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 07 May 2012 17:06:01 -0000
In-reply-to: <20120507135024.17700.85829.launchpad@ackee.canonical.com>
Reply-to: mp+104915@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

186	+ def isPowerSongFolder(self, dir):

This function is specific to an importer, it doesn't belong in the wizard. If you need to, extend the importer system to offer importers an opportunity to do checks.
-- 
https://code.launchpad.net/~sfindlay/openlp/select-folder-powersong/+merge/104915
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~sfindlay/openlp/select-folder-powersong into lp:openlp
From: Samuel Findlay, 2012-05-07