← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol/openlp/image-queue into lp:openlp

To: mp+107529@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Sun, 27 May 2012 05:14:18 -0000
In-reply-to: <20120526175817.13931.47641.launchpad@ackee.canonical.com>
Reply-to: mp+107529@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Line 115 and below should not be in "If save settings" block.
They close the database connections and clean up so yo need them to run regardless.
ServiceManager.cleanUp should also be called regardless.
-- 
https://code.launchpad.net/~googol/openlp/image-queue/+merge/107529
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol/openlp/image-queue into lp:openlp
From: Andreas Preikschat, 2012-05-26