← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~smpettit/openlp/portable into lp:openlp

To: mp+106992@xxxxxxxxxxxxxxxxxx
From: Samuel Findlay <samuel.findlay@xxxxxxxxx>
Date: Sun, 27 May 2012 11:30:23 -0000
In-reply-to: <20120523153955.22789.70679.codereview@gac.canonical.com>
Reply-to: mp+106992@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Stevan, just having another look at the new Settings class, I think there's one change to follow PyQt style conventions: class variable FilePath should be _filePath
-- 
https://code.launchpad.net/~smpettit/openlp/portable/+merge/106992
Your team OpenLP Core is requested to review the proposed merge of lp:~smpettit/openlp/portable into lp:openlp.

References

Re: [Merge] lp:~smpettit/openlp/portable into lp:openlp
From: Samuel Findlay, 2012-05-23