← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~sfindlay/openlp/refactor-song-import into lp:openlp

 

Review: Needs Fixing

I don't like the SongFormatAttr as a separate class (and I don't like the incomplete name), I'd prefer it to be part of SongFormat.

Additionally, if "availability" and co. are supposed to be enumeration items, then they should be PascalCase.
-- 
https://code.launchpad.net/~sfindlay/openlp/refactor-song-import/+merge/108170
Your team OpenLP Core is subscribed to branch lp:openlp.


References