openlp-core team mailing list archive

[Dave Warnock <dave@xxxxxxxxxxxxx>]

> Line 120 seems to be missing in the new code.  What is the impact on the
> calling code!

Tim,

It isn't missing. The exception does not do a return so the for loop kicks in and the transaction is done again. If it succeeds the 2nd (or 3rd) time then the return value is handled just as if it succeeded the first time. If it has not succeeded the 3rd time then the exception is passed back up the stack and so the return value is not needed.

Line 120 was a repeat of line 113 so now instead of repeated code line 113 will always be used.
-- 
https://code.launchpad.net/~dave-warnock/openlp/dbclean/+merge/109546
Your team OpenLP Core is subscribed to branch lp:openlp.