openlp-core team mailing list archive

[phill <phill.ridout@xxxxxxxxxxxxxx>]

On Jun 12, 2012 8:06 PM, "Raoul Snyman" <
raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Review: Needs Fixing

Can you clarify what you want? The current behaviour is:

Click Add/Edit verse try to close the dialog box by clicking save, to save
with out any text and there is a message box telling the user that there
needs to be text.

Click edit all, and leave it blank a stack trace occurs. Add only one line
and the stack trace occurs.

Save the song with no verses, and a message appears telling you that you
can't do that.

> You should be able to close the dialog via OK without any text in the
dialog. No text is also valid.

My fix fixes the edit all version of the dialog box. The edit (single
verse) is not affected.

If you were to remove all text, then this would delete all verses. And you
wouldn't be able to save the song.

-- 
https://code.launchpad.net/~phill-ridout/openlp/bug-1011286/+merge/109568
Your team OpenLP Core is subscribed to branch lp:openlp.