openlp-core team mailing list archive

[phill <phill.ridout@xxxxxxxxxxxxxx>]

Probably should have said:

A fix for issues: http://support.openlp.org/issues/703
http://support.openlp.org/issues/677

The bug was being caused because we were passing file paths for images and
presentations. In windows a back slash is used. This needed escaping

In my merge proposal.
On Jun 16, 2012 1:22 AM, "phill" <phill.ridout@xxxxxxxxxxxxxx> wrote:

> phill has proposed merging lp:~phill-ridout/openlp/ticket703+677 into
> lp:openlp.
>
> Requested reviews:
>  OpenLP Core (openlp-core)
>
> For more details, see:
> https://code.launchpad.net/~phill-ridout/openlp/ticket703+677/+merge/110642
> --
> https://code.launchpad.net/~phill-ridout/openlp/ticket703+677/+merge/110642
> You are the owner of lp:~phill-ridout/openlp/ticket703+677.
>
> === modified file 'openlp/plugins/remotes/html/openlp.js'
> --- openlp/plugins/remotes/html/openlp.js       2012-04-18 20:44:47 +0000
> +++ openlp/plugins/remotes/html/openlp.js       2012-06-16 00:21:19 +0000
> @@ -245,6 +245,9 @@
>         }
>         else {
>             $.each(data.results.items, function (idx, value) {
> +              if (typeof value[0] !== "number"){
> +                value[0] = OpenLP.escapeString(value[0])
> +              }
>               ul.append($("<li>").append($("<a>").attr("href", "#options")
>                   .attr("data-rel", "dialog").attr("value", value[0])
>                   .click(OpenLP.showOptions).text(value[1])));
>
>
>

-- 
https://code.launchpad.net/~phill-ridout/openlp/ticket703+677/+merge/110642
Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/ticket703+677 into lp:openlp.