openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol/openlp/trivial into lp:openlp

To: mp+110662@xxxxxxxxxxxxxxxxxx
From: Jonathan Corwin <j@xxxxxxxxxxxx>
Date: Sat, 16 Jun 2012 16:47:19 -0000
In-reply-to: <20120616160424.23069.35372.launchpad@ackee.canonical.com>
Reply-to: mp+110662@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

I'm not too keen on refactors/tidies at this stage, it's all too easy to introduce mistakes or miss a variable. However this time I will let it pass. Although wondering what verseId on line 162 did to upset you :)

Needs fixing for:
Rather than splitting the title if it contains any \n's (which will cause a blank title if there is a leading blank line), how about replacing them with a space and left trimming?
-- 
https://code.launchpad.net/~googol/openlp/trivial/+merge/110662
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol/openlp/trivial into lp:openlp
From: Andreas Preikschat, 2012-06-16