openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

You don't really need a whole class for two functions and a bunch of constants, do you? If you really feel the need you can create a new file/module (rtf.py?), but I don't see the need for a class (object-orientated vs class-orientated programming).


Just checking, this is mean to be a "P", not an "R"?

  406    + u'filter': u'%s (*.ptf)' % translate(


469	+ HOTKEY_TO_VERSE_TYPE = {
470	+ u'1': u'v1',
471	+ u'2': u'v2',
472	+ u'3': u'v3',
473	+ u'4': u'v4',
474	+ u'5': u'v5',
475	+ u'6': u'v6',
476	+ u'7': u'v7',
477	+ u'8': u'v8',
478	+ u'9': u'v9',
479	+ u'C': u'c',
480	+ u'+': u'b',
481	+ u'Z': u'o'}

Constants go at module-level, not class level.



-- 
https://code.launchpad.net/~mahfiaz/openlp/bug-933706/+merge/111937
Your team OpenLP Core is subscribed to branch lp:openlp.