openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #16291
[Merge] lp:~martin-barrett/openlp/printservice into lp:openlp
Martin Barrett has proposed merging lp:~martin-barrett/openlp/printservice into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #986688 in OpenLP: "Print Service copy does not separate verses"
https://bugs.launchpad.net/openlp/+bug/986688
For more details, see:
https://code.launchpad.net/~martin-barrett/openlp/printservice/+merge/112669
amended printservice.py so that copy as text spaces the verses properly, and html and preview printing is unaffected
--
https://code.launchpad.net/~martin-barrett/openlp/printservice/+merge/112669
Your team OpenLP Core is requested to review the proposed merge of lp:~martin-barrett/openlp/printservice into lp:openlp.
=== modified file 'openlp/core/ui/printserviceform.py'
--- openlp/core/ui/printserviceform.py 2012-06-22 14:14:53 +0000
+++ openlp/core/ui/printserviceform.py 2012-06-28 23:23:20 +0000
@@ -60,7 +60,7 @@
}
.itemText {
- margin-top: 10px;
+ margin-top: 5px;
}
.itemFooter {
@@ -218,6 +218,7 @@
if not verse_def or verse_def != slide[u'verseTag']:
text_div = self._addElement(u'div', parent=div,
classId=u'itemText')
+ self._addElement(u'br', parent=text_div)
else:
self._addElement(u'br', parent=text_div)
self._addElement(u'span', slide[u'html'], text_div)
Follow ups