← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~mahfiaz/openlp/bug-933706 into lp:openlp

 

Superfly, *.ptf is correct. Thanks for the idea. I changed it back into two functions again. I hope these constants found the right place.

Jonathan, you are right, I forgot to remove import of logging after I removed the logging part.
Although lines 205 and 611 look like an infinite loop, then AFAIK the only way to keep it running is to choose utf-8 every time it asks for the encoding. For all one-byte non-ascii characters, I don't think there are many encodings which do not cover the entire possible range (there might be none). Therefore you would never get an error again after you pick any non-utf encoding.
What it does is it postpones asking for the encoding until one is actually needed (rare for good RTFs anyway).
-- 
https://code.launchpad.net/~mahfiaz/openlp/bug-933706/+merge/113314
Your team OpenLP Core is subscribed to branch lp:openlp.


References