openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #16641
[Merge] lp:~googol/openlp/bug-1022831 into lp:openlp
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-1022831 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/bug-1022831/+merge/114515
fixed traceback when deleting last formatting tag form the list
[regression from r2031]
--
https://code.launchpad.net/~googol/openlp/bug-1022831/+merge/114515
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/bug-1022831 into lp:openlp.
=== modified file 'openlp/core/ui/formattingtagform.py'
--- openlp/core/ui/formattingtagform.py 2012-07-11 18:28:05 +0000
+++ openlp/core/ui/formattingtagform.py 2012-07-11 21:06:26 +0000
@@ -145,6 +145,9 @@
"""
if self.selected != -1:
FormattingTags.remove_html_tag(self.selected)
+ # As the first items are protected we should not have to take care
+ # of negative indexes causing tracebacks.
+ self.tagTableWidget.selectRow(self.selected - 1)
self.selected = -1
FormattingTags.save_html_tags()
self._reloadTable()
Follow ups