openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Review: Needs Fixing

Is the indent on line 46 correct?

I just tried a few random BibleGateway bibles.
I got the Het Boek bible and searched for exodus 10:4-10

This gave me the following trace:

Traceback (most recent call last):
  File "C:\Users\Jonathan\Documents\projects\openlp\bug-1049977\openlp\plugins\bibles\lib\mediaitem.py", line 762, in onQuickSearchButton
    self.search_results = self.plugin.manager.get_verses(bible, text)
  File "C:\Users\Jonathan\Documents\projects\openlp\bug-1049977\openlp\plugins\bibles\lib\manager.py", line 331, in get_verses
    return self.db_cache[bible].get_verses(reflist, show_error)
  File "C:\Users\Jonathan\Documents\projects\openlp\bug-1049977\openlp\plugins\bibles\lib\http.py", line 600, in get_verses
    search_results = self.get_chapter(book, reference[1])
  File "C:\Users\Jonathan\Documents\projects\openlp\bug-1049977\openlp\plugins\bibles\lib\http.py", line 629, in get_chapter
    return handler.get_bible_chapter(self.download_name, book, chapter)
  File "C:\Users\Jonathan\Documents\projects\openlp\bug-1049977\openlp\plugins\bibles\lib\http.py", line 240, in get_bible_chapter
    verse_list = self._extract_verses(span_list)
  File "C:\Users\Jonathan\Documents\projects\openlp\bug-1049977\openlp\plugins\bibles\lib\http.py", line 160, in _extract_verses
    verses.append((int(verse.strip()), text))
ValueError: invalid literal for int() with base 10: '4-5'

-- 
https://code.launchpad.net/~raoul-snyman/openlp/bug-1049977/+merge/124290
Your team OpenLP Core is subscribed to branch lp:openlp.