← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~trb143/openlp/media_icon into lp:openlp

 

Tim Bentley has proposed merging lp:~trb143/openlp/media_icon into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~trb143/openlp/media_icon/+merge/128347

Fix the icons for the media plugin so they are shown.
-- 
https://code.launchpad.net/~trb143/openlp/media_icon/+merge/128347
Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/media_icon into lp:openlp.
=== modified file 'openlp/plugins/media/lib/mediaitem.py'
--- openlp/plugins/media/lib/mediaitem.py	2012-06-22 14:14:53 +0000
+++ openlp/plugins/media/lib/mediaitem.py	2012-10-06 09:34:24 +0000
@@ -42,7 +42,7 @@
 
 log = logging.getLogger(__name__)
 
-CLAPPERBOARD = QtGui.QImage(u':/media/media_video.png')
+CLAPPERBOARD = QtGui.QImage(u':/media/image_clapperboard.png')
 #TODO: Add an appropriate Icon for DVDs, CDs, ...
 DVD_ICON = QtGui.QImage(u':/media/media_video.png')
 
@@ -225,7 +225,7 @@
 
     def initialise(self):
         self.listView.clear()
-        self.listView.setIconSize(QtCore.QSize(88, 50))
+        self.listView.setIconSize(QtCore.QSize(44, 25))
         self.loadList(SettingsManager.load_list(self.settingsSection, u'media'))
         self.populateDisplayTypes()
 
@@ -290,7 +290,7 @@
             key=lambda filename: os.path.split(unicode(filename))[1].lower())
         for track in media:
             track_info = QtCore.QFileInfo(track)
-            if not track_info.isFile():
+            if track_info.isFile():
                 filename = os.path.split(unicode(track))[1]
                 item_name = QtGui.QListWidgetItem(filename)
                 item_name.setIcon(build_icon(CLAPPERBOARD))


Follow ups