openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

6	except AttributeError:
7	log.warn(u'Failure to find desktop - Impress may have closed')
8	+ except pywintypes.com_error:
9	+ log.warn(u'Failure to find desktop - Impress may have closed')


Rather put the two exceptions together, less code duplication:

    except (AttributeError, pywintypes.com_error):
        log.warn(...)

27	+ if not self.control:
28	+ return False
29	+ return self.control.isRunning()

Just for kicks, if you want to, you can do this:

    return self.control.isRunning() if self.control else False


-- 
https://code.launchpad.net/~j-corwin/openlp/bug-927585/+merge/129527
Your team OpenLP Core is subscribed to branch lp:openlp.