openlp-core team mailing list archive

[phill <phill.ridout@xxxxxxxxxxxxxx>]

phill has proposed merging lp:~phill-ridout/openlp/1073061 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #1073061 in OpenLP: "Song importer repeatVerse function crashes on no verse order"
  https://bugs.launchpad.net/openlp/+bug/1073061

For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1073061/+merge/132757

Fix for bug#1073061
-- 
https://code.launchpad.net/~phill-ridout/openlp/1073061/+merge/132757
Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/1073061 into lp:openlp.

=== modified file 'openlp/plugins/songs/lib/songimport.py'
--- openlp/plugins/songs/lib/songimport.py	2012-10-21 14:07:57 +0000
+++ openlp/plugins/songs/lib/songimport.py	2012-11-02 22:07:22 +0000
@@ -274,9 +274,10 @@
         """
         Repeat the previous verse in the verse order
         """
-        self.verseOrderListGenerated.append(
-            self.verseOrderListGenerated[-1])
-        self.verseOrderListGeneratedUseful = True
+        if self.verseOrderListGenerated:
+            self.verseOrderListGenerated.append(
+                self.verseOrderListGenerated[-1])
+            self.verseOrderListGeneratedUseful = True
 
     def checkComplete(self):
         """