← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~marmyshev/openlp/autoplay into lp:openlp

 

Review: Needs Fixing

First point is we are not merging new features until 2.0 is out.

Secondly if you are going to do this would not a simple dialog be better to set the values rather than rely on the default value.
What happens if we need a different value for each service item.
Having 3 menu items on the service context is over kill and would be fixed by a dialogue.
You could then use the hover display to show the values. 


162-163???? Whay
165 should be in SlideController not servicemanager.
-- 
https://code.launchpad.net/~marmyshev/openlp/autoplay/+merge/133739
Your team OpenLP Core is subscribed to branch lp:openlp.


References