openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Andreas Preikschat has proposed merging lp:~googol/openlp/bug-1050081 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #1050081 in OpenLP: "display screen - hide mouse by default"
  https://bugs.launchpad.net/openlp/+bug/1050081

For more details, see:
https://code.launchpad.net/~googol/openlp/bug-1050081/+merge/137444

Hello,

- fixed #1050081 'display screen - hide mouse by default'

I changed the code/fixed it, but I am not sure if you agree with that.

Should that setting be activated by default?
-- 
https://code.launchpad.net/~googol/openlp/bug-1050081/+merge/137444
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/bug-1050081 into lp:openlp.

=== modified file 'openlp/core/ui/advancedtab.py'
--- openlp/core/ui/advancedtab.py	2012-12-01 07:57:54 +0000
+++ openlp/core/ui/advancedtab.py	2012-12-02 20:36:21 +0000
@@ -477,7 +477,7 @@
             settings.value(u'enable exit confirmation',
             QtCore.QVariant(True)).toBool())
         self.hideMouseCheckBox.setChecked(
-            settings.value(u'hide mouse', QtCore.QVariant(False)).toBool())
+            settings.value(u'hide mouse', QtCore.QVariant(True)).toBool())
         self.serviceNameDay.setCurrentIndex(
             settings.value(u'default service day',
             QtCore.QVariant(self.defaultServiceDay)).toInt()[0])

=== modified file 'openlp/core/ui/maindisplay.py'
--- openlp/core/ui/maindisplay.py	2012-12-01 07:57:54 +0000
+++ openlp/core/ui/maindisplay.py	2012-12-02 20:36:21 +0000
@@ -498,7 +498,7 @@
         Hide mouse cursor when moved over display.
         """
         if Settings().value(u'advanced/hide mouse',
-            QtCore.QVariant(False)).toBool():
+            QtCore.QVariant(True)).toBool():
             self.setCursor(QtCore.Qt.BlankCursor)
             self.frame.evaluateJavaScript('document.body.style.cursor = "none"')
         else:

=== modified file 'openlp/core/ui/media/vlcplayer.py'
--- openlp/core/ui/media/vlcplayer.py	2012-12-01 07:57:54 +0000
+++ openlp/core/ui/media/vlcplayer.py	2012-12-02 20:36:21 +0000
@@ -115,8 +115,7 @@
         if not display.hasAudio:
             command_line_options += u' --no-audio --no-video-title-show'
         if Settings().value(u'advanced/hide mouse',
-            QtCore.QVariant(False)).toBool() and \
-            display.controller.isLive:
+            QtCore.QVariant(True)).toBool() and display.controller.isLive:
             command_line_options += u' --mouse-hide-timeout=0'
         display.vlcInstance = vlc.Instance(command_line_options)
         display.vlcInstance.set_log_verbosity(2)