← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~patrick-zakweb/openlp/bug-936281 into lp:openlp

 

> Is Line 16 in the correct place?  Is it needed or should it be with 11?

As before the large stylesheet block now called "nt_repair_stylesheet" should only be loaded on Windows.
The removal of alternating row colors is not operating system dependent. So I guess it's correct the way it is.

> Line 82 should this be 'nt' not starts with 'win'?

I tried to keep the style consistent. In advancedtab.py the sys.platform was used a few lines above, so I thought I should probably also use it. If you still think I should use os.name I will change it.
-- 
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281/+merge/138884
Your team OpenLP Core is subscribed to branch lp:openlp.


References