openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Had 5 mins to have a look and I must say it is better but still cannot
understand why it needed a re-write.
It is buggy though.

1) Restore Defaults should set the list back to the default list.  It does
not.
2) Hit new and it creates a new line.  Good.  Add a tag and another new
line appears.  Bug
3) You cannot delete the final blank line it is always present cos you need
a tag to enable delete and this auto creates a new line.

Playing with random inputs gave me

Traceback (most recent call last):

File
"/home/tim/Projects/openlp/formattingtags/openlp/core/ui/formattingtagform.py",
line 153, in on_current_cell_changed

item.setText(data.get(u'tag'))
TypeError: QTableWidgetItem.setText(QString): argument 1 has unexpected
type 'NoneType'




On 19 December 2012 17:26, Jonathan Corwin <j@xxxxxxxxxxxx> wrote:

> My guess is Tim is expecting it to force end html to be entered. However
> saying that, it doesn't currently force this in trunk, so I don't know why
> it is important here. Also doing so might prevent self closing standalone
> tags such as <hr />
>
> --
> https://code.launchpad.net/~m2j/openlp/formattingtags/+merge/140652
> You are requested to review the proposed merge of
> lp:~m2j/openlp/formattingtags into lp:openlp.
>



-- 
Tim and Alison Bentley
Home@xxxxxxxxxxxxxxx

https://code.launchpad.net/~m2j/openlp/formattingtags/+merge/140652
Your team OpenLP Core is subscribed to branch lp:openlp.