← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~patrick-zakweb/openlp/bug-936281-newformat into lp:openlp

To: mohij <patrick@xxxxxxxxx>
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Tue, 01 Jan 2013 09:28:21 -0000
In-reply-to: <20121230120526.22086.26427.launchpad@ackee.canonical.com>
Reply-to: mp+141485@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

88, 90 why the local variable why not set to True and the False as we do in the rest of the code?

116-117 can this fit on one line?

Not sure about "Workarounds".  "Display overrides" ?  check with Raoul!
-- 
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge/141485
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~patrick-zakweb/openlp/bug-936281-newformat into lp:openlp
From: mohij, 2012-12-30