openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #18657
[Merge] lp:~raoul-snyman/openlp/tests into lp:openlp
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/tests into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1094346 in OpenLP: "SIP version 2 rewrite broke automated test"
https://bugs.launchpad.net/openlp/+bug/1094346
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142251
Fix an erroneous and unused import in a test.
There was an unused imported function which doesn't exist in the version of Mock which is installed on the CI server. I removed the imported function, and all the tests still pass, so hopefully now the automated tests won't fail anymore.
--
https://code.launchpad.net/~raoul-snyman/openlp/tests/+merge/142251
Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/tests into lp:openlp.
=== modified file 'tests/functional/openlp_core_lib/test_lib.py'
--- tests/functional/openlp_core_lib/test_lib.py 2013-01-07 12:05:19 +0000
+++ tests/functional/openlp_core_lib/test_lib.py 2013-01-08 07:16:21 +0000
@@ -3,7 +3,7 @@
"""
from unittest import TestCase
-from mock import MagicMock, patch, call
+from mock import MagicMock, patch
from openlp.core.lib import str_to_bool, translate, check_directory_exists, get_text_file_string
Follow ups