openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~marmyshev/openlp/item_title into lp:openlp

To: Dmitriy Marmyshev <marmyshev@xxxxxxxxx>
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Fri, 11 Jan 2013 16:49:29 -0000
In-reply-to: <20130111162927.12714.14636.launchpad@ackee.canonical.com>
Reply-to: mp+142941@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Please look at the use of Title within the service item as this change is will break OpenLP.

The title you are editing is not always displayed but is been used to store information about players.  Media and Presentations 

I suggest you have a look at ServiceItem class.  
Also you need to use the methods on the serviceitem class in servicemanager not play with it's internals 
 


-- 
https://code.launchpad.net/~marmyshev/openlp/item_title/+merge/142941
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~marmyshev/openlp/item_title into lp:openlp
From: Dmitriy Marmyshev, 2013-01-11