openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

The proposal to merge lp:~googol/openlp/central-settings-place into lp:openlp has been updated.

Description changed to:

Hello,

NOTE:
There a still to bugs: 1) The translated string is not translated and 2) the defaults for the display screen are not taken from the current screen (instead build in defaults are used).
I still would like you to review my branch...
(And sure, I'll remove the print statement as well)

- fixed bug #1096559 (Central place for default settings)

I reworked the settings management. All core settings are now stored in the Settings class. The plugin settings are stored in the <my>plugin.py file. On start up the plugin settings are pulled in the central dict.

I also implemented a central dict to store old and replaced settings. This allows us to rename settings without losing the value saved.

Together with this rework I moved/splitted a few files.
Namely, I have moved the ScreenList class from openlp/core/ui to openlp/core/lib. When you look at trunk you'll see that in most cases the ScreenList was the only class imported from ui (indicating that it does not belong to ui). And basically the ScreenList is just like the ImageManager. It does not really display anything.
Furthermore, I splitted the ui.py file. Now we have a uistrings.py and ui.py file. While programming I noticed, that the UiStrings class does not require any module (other then the translate function).

In both cases (ScreenList and UiStrings) they caused import errors because importing them triggered other imports pointing to openlp.ui.Whatever; which then triggered the import of openlp.core.ui(.__init__) .

I hope that makes sense to you :)

For more details, see:
https://code.launchpad.net/~googol/openlp/central-settings-place/+merge/143020
-- 
https://code.launchpad.net/~googol/openlp/central-settings-place/+merge/143020
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/central-settings-place into lp:openlp.