openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~arjan-i/openlp/images_groups into lp:openlp

To: Arjan Schrijver <arjan@xxxxxxxxxx>
From: Raoul Snyman <raoul@xxxxxxxxxxx>
Date: Thu, 31 Jan 2013 17:52:24 -0000
In-reply-to: <20130130194819.6100.76189.launchpad@ackee.canonical.com>
Reply-to: mp+145709@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Loading images without an image group doesn't work properly... the "select group" dialog shows up, with no groups, or any ability to create new groups, and then clicking OK does nothing. AT LEAST show an error message that there needs to be at least one group, and add the ability to add a new group to the select dialog.

Also, your dialog is lopsided, with the select box all the way in the top left corner, but I'll send you a diff with a better layout.
-- 
https://code.launchpad.net/~arjan-i/openlp/images_groups/+merge/145709
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~arjan-i/openlp/images_groups into lp:openlp
From: Arjan Schrijver, 2013-01-30