openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

140	+ mocked_qt.PYQT_VERSION_STR = u'4.9'
141	+ mocked_qt.qVersion.return_value = u'4.8'
142	+ mocked_createSeparatedList.return_value = u'Author 1, Author 2, and Author 3'
143	+
144	+ # GIVEN: A list of strings.
145	+ string_list = [u'Author 1', u'Author 2', u'Author 3']

Setting up the mocks should be in the GIVEN too, like so:

    # GIVEN: Preset PyQt4 and Qt versions, and a list of authors
    mocked_qt.PYQT_VERSION_STR = u'4.9'
    mocked_qt.qVersion.return_value = u'4.8'
    mocked_createSeparatedList.return_value = u'Author 1, Author 2, and Author 3'
    string_list = [u'Author 1', u'Author 2', u'Author 3']


159	+ mocked_qt.PYQT_VERSION_STR = u'4.8'
160	+ mocked_qt.qVersion.return_value = u'4.7'
161	+
162	+ # GIVEN: A list of strings.
163	+ string_list = []

Same thing again:

    # GIVEN: Preset PyQt4 and Qt versions, and an empty list
    mocked_qt.PYQT_VERSION_STR = u'4.8'
    mocked_qt.qVersion.return_value = u'4.7'
    string_list = []


And so on and so forth...
-- 
https://code.launchpad.net/~googol/openlp/bug-1100277/+merge/146971
Your team OpenLP Core is subscribed to branch lp:openlp.