openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~patrick-zakweb/openlp/duplicate-removal-review into lp:openlp

To: mohij <patrick@xxxxxxxxx>
From: Raoul Snyman <raoul@xxxxxxxxxxx>
Date: Thu, 14 Feb 2013 05:17:19 -0000
In-reply-to: <20130213232530.17035.84121.launchpad@ackee.canonical.com>
Reply-to: mp+148345@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Our naming conventions now solely follow Python/PEP8 standards, so no more camelCase names.

You also have a conflict which needs to be resolved, probably due to a recent commit. Merge trunk into your branch and resolve the conflict in your branch.

Why do you implement customInit() only to "pass" it?

There are a few other things that I'm not entirely happy with, but I need to look at it on my PC, rather tjan my phone.
-- 
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/148345
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~patrick-zakweb/openlp/duplicate-removal-review into lp:openlp
From: mohij, 2013-02-13