← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

To: Raoul Snyman <raoul@xxxxxxxxxxx>
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Sat, 16 Feb 2013 10:04:21 -0000
In-reply-to: <20130215193447.28782.3261.codereview@chaenomeles.canonical.com>
Reply-to: mp+147841@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

> You add 21 tests in one merge proposal, and I'll implement your change.
> Otherwise, I'm committing this.

Sure you can commit this. But as we have many proposals right now, I thought I might be better when you change it (prevent conflicts etc.).
-- 
https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147841
Your team OpenLP Core is subscribed to branch lp:openlp.

References

Re: [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp
From: Raoul Snyman, 2013-02-15