openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

> But it's not testing you're always getting the tags correctly. All it's
> testing is the function returns the same thing twice. It could be returning a
> collection of turnips.

So are we going to *assume* that the function always returns the same thing or do we want to test it?

=== modified file 'openlp/core/lib/formattingtags.py'
--- openlp/core/lib/formattingtags.py	2013-02-05 08:05:28 +0000
+++ openlp/core/lib/formattingtags.py	2013-02-16 11:44:50 +0000
@@ -78,7 +78,6 @@
         """
         temporary_tags = [tag for tag in FormattingTags.html_expands
             if tag.get(u'temporary')]
-        FormattingTags.html_expands = []
         base_tags = []
         # Append the base tags.
         # Hex Color tags from http://www.w3schools.com/html/html_colornames.asp

Simple change causing the test to fail after I will have committed a fix ;)
-- 
https://code.launchpad.net/~googol/openlp/tests/+merge/148748
Your team OpenLP Core is subscribed to branch lp:openlp.