openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~patrick-zakweb/openlp/duplicate-removal-review into lp:openlp

To: mohij <patrick@xxxxxxxxx>
From: Raoul Snyman <raoul@xxxxxxxxxxx>
Date: Mon, 18 Feb 2013 19:21:23 -0000
In-reply-to: <20130218190218.8048.18422.launchpad@ackee.canonical.com>
Reply-to: mp+149130@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

I don't see the point in your DuplicateSongFinder class. You could quite easily make those methods into functions, and your constant object attributes into constants, and skip the memory overhead of the class + object.

This is Python, we don't need classes everywhere :-)

Ping me in IRC if you need any help/guidance/direction/etc.
-- 
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/149130
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~patrick-zakweb/openlp/duplicate-removal-review into lp:openlp
From: mohij, 2013-02-18