openlp-core team mailing list archive

[mohij <patrick@xxxxxxxxx>]

> What is this for?  Very non standard,
>  self.emit(QtCore.SIGNAL(u'song_remove_button_clicked(PyQt_PyObject)'), self)

You proposed to replace the Qt signal-slot mechanism here with the Registry.register-function/execute mechanism. I disagree here. My intent is to keep the SongReviewWidget decoupled from the one using it. This allows other code to also make use of this class. The Registry is not as flexible as the signal-slot mechanism, because it does not allow to dynamically connect signals and slots. With the registry it is impossible to make one SongReviewWidget call the DuplicateSongRemovalForm.song_remove_button_clicked and a different SongReviewWidget call a different function at the same time. As the code is now I could get away with using the Registry, but once some other object also used the SongReviewWidget and both want to have the connection established at the same time stuff breaks.
-- 
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/149144
Your team OpenLP Core is subscribed to branch lp:openlp.