openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

355	- }
356	+}

1102	- }
1103	+}

Are those indentation change correct? It doesn't look right compared to the line above it.


1312	+ Package to test the openlp.core.lib package.

I'd prefer it if the docstring matched the module.


1330	+ self.application = QtGui.QApplication.instance()
1331	+ self.application.setOrganizationName(u'OpenLP-tests')
1332	+ self.application.setOrganizationDomain(u'openlp.org')
1333	+ Settings()

Use Settings.setFileName() to set a temporary file... I did it in the plugin manager tests, I think.
-- 
https://code.launchpad.net/~trb143/openlp/settings_migration/+merge/149150
Your team OpenLP Core is subscribed to branch lp:openlp.