← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~phill-ridout/openlp/1114457_2.0 into lp:openlp/2.0

To: mp+149372@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul@xxxxxxxxxxx>
Date: Tue, 19 Feb 2013 21:47:18 -0000
In-reply-to: <20130219191219.23627.88332.launchpad@ackee.canonical.com>
Reply-to: mp+149372@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

35	+ self.importWizard.progressBar.setMaximum(total_count)

Wouldn't it be more efficient to unindent this so that you only run that method once and not in every iteration of the loop?
-- 
https://code.launchpad.net/~phill-ridout/openlp/1114457_2.0/+merge/149372
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.

References

[Merge] lp:~phill-ridout/openlp/1114457_2.0 into lp:openlp/2.0
From: Phill, 2013-02-19