openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

731	+        self.mocked_main_window.file_import_menu.return_value = True
732	+        self.mocked_main_window.file_export_menu.return_value = True
733	+        self.mocked_main_window.file_export_menu.return_value = True

If these methods are supposed to return true, then this is OK. If they're not supposed to return anything, make them return None.


759	+        #self.assertEqual(self.mocked_settings_form.plugin_manager.plugins, plugin_manager.plugins,
760	+        #    u'The plugins on the settings form should be the same as the plugins in the plugin manager')

Don't comment stuff out, remove it. And if you're removing an assert, make sure you update the THEN statement too. And in this particular case, should you really be removing the assert, or should you not actually be rewriting the test?
-- 
https://code.launchpad.net/~trb143/openlp/bootstrap/+merge/150622
Your team OpenLP Core is subscribed to branch lp:openlp.